Repository navigation
fix(sdk): request callbacks, timeouts and logs without user data (DEV-4719) - #234
Merged
Merged
Conversation
…tly one callback; a callback of the app that throws no longer crashes it; a silent server ends in onError after 10 s; a clicked push keeps off the code of story and push events; requests are logged by method and path, without the user's data
… longer reach the app's release build
… onSuccess that fails ends in one onError(-1), so a parse error inside the SDK still reaches the app; error answers are logged without their body
…and path, without did, session or answers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the SDK audit (DEV-4719):
onSuccess. Other codes, 3xx included, reachonErrorwith their status.onSuccessoronError. IfonSuccessthrows (the SDK's own parsing included), oneonError(-1)follows. A callback that throws no longer crashes the app.onError.codeof story and push events.excluded_merchantswithoutlocationstoo./initanswer. The same goes for the v3 stories, polls and popups client.